Skip to content

Only run tests if tests are enabled#7

Merged
eric-wieser merged 1 commit intoeric-wieser:masterfrom
awesomebytes:patch-1
Apr 30, 2018
Merged

Only run tests if tests are enabled#7
eric-wieser merged 1 commit intoeric-wieser:masterfrom
awesomebytes:patch-1

Conversation

@awesomebytes
Copy link
Copy Markdown
Contributor

On a system where tests are not run by default ros_numpy fails to build with:

CMake Error at /home/nao/gentoo/opt/ros/kinetic/share/catkin/cmake/test/tests.cmake:18 (message):
  () is not available when tests are not enabled.  The CMake code should only
  use it inside a conditional block which checks that testing is enabled:

  if(CATKIN_ENABLE_TESTING)

    (...)

  endif()

Call Stack (most recent call first):
  CMakeLists.txt:181 (catkin_add_nosetests)

So... just following with what is suggested.

@awesomebytes
Copy link
Copy Markdown
Contributor Author

Just a little bump @eric-wieser , and reminding I offered myself in the PR: #6 as a maintainer of the package to release new versions and so.

@eric-wieser
Copy link
Copy Markdown
Owner

It looks like you've found a bug upstream in ROS here too - there's supposed to be something before those ()

@eric-wieser eric-wieser merged commit 40e8eb5 into eric-wieser:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants