Django 1.7, 1.8 and Python 3.x compatibility#45
Open
krallin wants to merge 11 commits intoericflo:masterfrom
Open
Django 1.7, 1.8 and Python 3.x compatibility#45krallin wants to merge 11 commits intoericflo:masterfrom
krallin wants to merge 11 commits intoericflo:masterfrom
Conversation
Fixed in upstream development branch as well: ericflo@c2ec7c5 https://code.google.com/p/django-pagination/issues/detail?id=8
The tests rely on this
The newer Django test runners don't execute doctests
krallin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
This PR is more there to highlight an issue than to propose an actual fix, but:
https://github.com/ericflo/django-pagination/blob/master/pagination/templatetags/pagination_tags.py#L144
I suppose an actual fix should actually check for Python 2: there's no use coercing the range to a list on Python 3 as a Python 3 range can be sliced.