-
-
Notifications
You must be signed in to change notification settings - Fork 20
fix: sort-keys autofix fully sorts keys in a single pass #235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
crimsonjay0
wants to merge
5
commits into
eslint:main
Choose a base branch
from
crimsonjay0:sort-keys-single-pass-autofix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
af2baf6
fix: sort-keys autofix fully sorts keys in a single pass
crimsonjay0 0967bf6
Merge branch 'main' into sort-keys-single-pass-autofix
crimsonjay0 3ed65a5
Merge branch 'main' into sort-keys-single-pass-autofix
crimsonjay0 93c723f
refactor
crimsonjay0 f8217ed
use toSorted and add test case for duplicate keys
crimsonjay0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for other reviewers: This would change the current behavior of reporting every unsorted key but only fixing the first group (because of the
breakafter thecontext.report). I think this behavior is okay as the other groups will be fixed in subsequent rounds. The alternative would be to group everything and do the fixes for every group.