Skip to content

Fix cache-control header for 404 requests #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ije merged 1 commit into from
Jul 12, 2025
Merged

Fix cache-control header for 404 requests #1169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions server/router.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1467,7 +1467,7 @@ func esmRouter(db Database, buildStorage storage.Storage, logger *log.Logger) re
case output := <-ch:
if output.err != nil {
if output.err.Error() == "types not found" {
ctx.SetHeader("Cache-Control", ccImmutable)
ctx.SetHeader("Cache-Control", fmt.Sprintf("public, max-age=%d", config.NpmQueryCacheTTL))
return rex.Status(404, "Types Not Found")
}
return rex.Status(500, "Failed to build types: "+output.err.Error())
Expand Down Expand Up @@ -1583,11 +1583,7 @@ func esmRouter(db Database, buildStorage storage.Storage, logger *log.Logger) re
if output.err != nil {
msg := output.err.Error()
if msg == "could not resolve build entry" || strings.HasSuffix(msg, " not found") || strings.Contains(msg, "is not exported from package") || strings.Contains(msg, "no such file or directory") {
if strings.HasPrefix(msg, "version ") && strings.HasSuffix(msg, " not found") {
ctx.SetHeader("Cache-Control", fmt.Sprintf("public, max-age=%d", config.NpmQueryCacheTTL))
} else {
ctx.SetHeader("Cache-Control", ccImmutable)
}
ctx.SetHeader("Cache-Control", fmt.Sprintf("public, max-age=%d", config.NpmQueryCacheTTL))
return rex.Status(404, msg)
}
return rex.Status(500, msg)
Expand Down
Loading