Skip to content

Add EspNetif::set_ip_info - #398

Open
torkleyy wants to merge 2 commits into
esp-rs:masterfrom
torkleyy:set-ip-pr
Open

Add EspNetif::set_ip_info#398
torkleyy wants to merge 2 commits into
esp-rs:masterfrom
torkleyy:set-ip-pr

Conversation

@torkleyy

Copy link
Copy Markdown
Contributor

Fixes #332

@torkleyy
torkleyy force-pushed the set-ip-pr branch 3 times, most recently from cf40c85 to e3b919f Compare March 25, 2024 09:26
@torkleyy

Copy link
Copy Markdown
Contributor Author

Probably we will also need a method to reenable DHCP.

@ivmarkov

Copy link
Copy Markdown
Collaborator

Limited access to internet right now. Will follow up when I have an opportunity

@torkleyy

Copy link
Copy Markdown
Contributor Author

Sure, there's no rush.

@Vollbrecht

Copy link
Copy Markdown
Collaborator

from the issue conversation ivmarkov thought that it may be problematic to update such values when the netif is in the up state, But you thought based on the docu that it still should work. So you can confirm that calling esp_netif_set_ip_info does not produce sideeffects / e.g its save to be callable in any state?

@Vollbrecht

Copy link
Copy Markdown
Collaborator

@ivmarkov @torkleyy bumping anything you have to say here to bring this forward?

@torkleyy

Copy link
Copy Markdown
Contributor Author

I haven't tested this much as we follow a different approach atm. In any case there is no way to reenable DHCP with just this method added.

@torkleyy

Copy link
Copy Markdown
Contributor Author

FYI, we've been using this in production for many months now, we noticed that for wifi, you have to disconnect and reconnect for it to take effect - this is not the case for Ethernet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot change network interface after creation

3 participants