Skip to content

Fixes issue #585 -> Resolve contains() method returning false for existing string values #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ivmarkov merged 29 commits into from
Jul 30, 2025
Merged

Fixes issue #585 -> Resolve contains() method returning false for existing string values #588

Show file tree
Hide file tree
Changes from 17 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
e3fe0a4
fix(nvs): resolve contains() method returning false for existing stri…
danielmeza Jul 25, 2025
4f82b9b
Fix format
danielmeza Jul 25, 2025
f0e1fff
Add derives to NvsDataType and clean up error handling
danielmeza Jul 25, 2025
ce96f7a
Update nvs.rs
danielmeza Jul 25, 2025
b73d037
Refactor key type checks to use find_key_type helper
danielmeza Jul 25, 2025
fb885ec
Fix format
danielmeza Jul 25, 2025
e048cce
Refactor NVS storage types and remove duplicate code
danielmeza Jul 25, 2025
2cb5965
Fix field access spacing in EspKeyValueStorage
danielmeza Jul 25, 2025
b1738d0
Fix NVS handle usage and update target architecture
danielmeza Jul 25, 2025
7f21855
Fix spacing in nvs_erase_key call
danielmeza Jul 25, 2025
064c83e
Fix trait method calls to use correct struct
danielmeza Jul 25, 2025
04927e4
Add repr(u8) to NvsDataType and simplify conversion
danielmeza Jul 25, 2025
f52b312
Add remove method to EspKeyValueStorage
danielmeza Jul 25, 2025
3e53e4e
Restore convertion
danielmeza Jul 25, 2025
5a5b169
Fix format
danielmeza Jul 25, 2025
24cfb55
Allow non-upper case globals in NvsDataType impl
danielmeza Jul 25, 2025
386bd66
Add version gating to NVS key query methods
danielmeza Jul 26, 2025
1ada88b
Refactor NVS data type handling and storage API
danielmeza Jul 26, 2025
52863a1
Update target configuration and refactor NVS key-value storage implem…
danielmeza Jul 26, 2025
09c8582
Add version-specific impls for EspKeyValueStorage
danielmeza Jul 26, 2025
5a26746
Remove unused import
danielmeza Jul 26, 2025
65766bd
Remove mutability from base remove() method
danielmeza Jul 26, 2025
bbad284
Update nvs_get_set_raw_storage.rs
danielmeza Jul 26, 2025
d328391
Format code
danielmeza Jul 26, 2025
7207fe6
Remove redundant return statement in blob_len call
danielmeza Jul 26, 2025
7116cb8
Update nvs.rs
danielmeza Jul 27, 2025
2815a89
Update nvs_get_set_raw_storage.rs
danielmeza Jul 27, 2025
d07f4c2
Remove mutable binding from storage variable
danielmeza Jul 28, 2025
99f9692
Remove unused EspKeyValueStorage impl for newer ESP-IDF
danielmeza Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[build]
target = "riscv32imc-esp-espidf"
#target = "xtensa-esp32-espidf"
# target = "riscv32imc-esp-espidf"
Comment thread
ivmarkov marked this conversation as resolved.
Outdated
target = "xtensa-esp32-espidf"

[target.xtensa-esp32-espidf]
linker = "ldproxy"
Expand Down
2 changes: 1 addition & 1 deletion examples/nvs_get_set_raw_storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ fn main() -> anyhow::Result<()> {
let nvs_default_partition: EspNvsPartition<NvsDefault> = EspDefaultNvsPartition::take()?;

let test_namespace = "test_ns";
let nvs = match EspNvs::new(nvs_default_partition, test_namespace, true) {
let nvs = match EspKeyValueStorage::new(nvs_default_partition, test_namespace, true) {
Ok(nvs) => {
info!("Got namespace {test_namespace:?} from default partition");
nvs
Expand Down
Loading