BT: Advertising does not work with ESP-IDF 5.5+ - #670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution!
We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:
Submission Checklist 📝
cargo fmtcommand to ensure that all changed code is formatted correctly.cargo clippycommand to ensure that all changed code passes latest Clippy nightly lints.CHANGELOG.mdin the proper section.Pull Request Details 📖
Description
This PR is addressing:
Cmd Disallowedon ESP32-S3 sysgrok/esp-idf-matter#30Both of these are caused by a wrong spelling of an ESP-IDF cfg version guard: "_least" instead of "_at_least".
Chips affected: esp32c3, esp32s3, likely the classic esp32 as well.
Additionally, following extra fixes:
ExtendedAdvertising*events are no longer mis-mapped asOtherScanDuplicate::Resetin thegapmodule was gated onesp_idf_ble_50_feature_supportinstead ofesp_idf_bt_ble_50_features_supported.Testing
Tested with
esp-idf-matter