Update action to support multiple YAML configuration files#100
Update action to support multiple YAML configuration files#100bomberstudios wants to merge 2 commits into
Conversation
…e manifest generation
jesserockz
left a comment
There was a problem hiding this comment.
Thanks for the work on this — I like the idea of supporting multiple files, but I don't think we can land it in its current shape: the action outputs become ambiguous once more than one config is processed.
get_config appends to $GITHUB_OUTPUT once per config, so GitHub's "last write wins" semantics take over — name and original-name only reflect the last config, and project-name/project-version aren't reset between configs, so they can end up reporting one config's project metadata while name reports another's. Anyone whose workflow uses ${{ steps.build.outputs.name }} to locate artifacts (the pattern in our own ci.yml) will silently get just one of the N folders and drop the rest, including the combined root manifest.json.
If every config in the list happens to produce the same name and metadata it'll appear to work, but the failure mode for anyone using it "wrong" is silent data loss followed by a confused bug report.
The feature needs to handle the whole flow — outputs, artifact layout, manifest discovery — as a coherent design before we merge. Happy to discuss what shape would work best (JSON-array outputs, a manifest-path output, etc.).
Jesse
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Also, enhances manifest generation for multiple configurations
Closes #99