Skip to content

cap_im_tg: bound accumulated Telegram HTTP response size #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orbisai0security wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cap_im_tg: bound accumulated Telegram HTTP response size #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions components/claw_capabilities/cap_im_platform/src/cap_im_tg.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,8 @@ static bool cap_im_tg_dedup_check_and_record(const char *update_key)
return false;
}

#define CAP_IM_TG_MAX_RESP_SIZE (64U * 1024U)

Comment on lines +131 to +132
static esp_err_t cap_im_tg_http_event_handler(esp_http_client_event_t *event)
{
cap_im_tg_http_resp_t *resp = (cap_im_tg_http_resp_t *)event->user_data;
Expand All @@ -136,6 +138,10 @@ static esp_err_t cap_im_tg_http_event_handler(esp_http_client_event_t *event)
return ESP_OK;
}

if (resp->len + (size_t)event->data_len + 1 > CAP_IM_TG_MAX_RESP_SIZE) {
return ESP_ERR_NO_MEM;
}
Comment on lines +141 to +143

if (resp->len + (size_t)event->data_len + 1 > resp->cap) {
char *tmp = NULL;
size_t new_cap = resp->cap * 2;
Expand Down