perf(result-table): move cell decode validation into build_plan - #173
Merged
Conversation
Introduce a typed per-cell decode plan so schema-dependent validation and scale precomputation run once per table instead of once per cell. - FromCell gains an associated Plan, build_plan(&Column), and from_cell_with_plan(raw, plan); type-compatibility checks move to plan build time and surface as SchemaError::IncompatibleColumnType. - Add CellPlan<T> and RowRef::get_planned; remove RowRef::get. - Tuple and derive FromRow plans store typed CellPlan values. - Precompute timestamp/time scale factors; keep scale-based wrappers for the dynamic decode path. - Add a timestamp-heavy decode benchmark.
Rename the planned row access helper to get_with_plan and make the CellPlan field name describe the stored decode plan. Refresh related documentation and error text so schema validation and incompatible column type wording match the plan-building behavior.
yuly3
marked this pull request as ready for review
July 4, 2026 05:48
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.