perf: decode collect partitions as they commit - #180
Merged
Conversation
Rework ResultCursor/TypedResultCursor collect paths to decode each partition and drop its raw storage before folding in the next one, instead of merging every partition into one ResultTable before decode. Peak partition storage drops from the whole result set to the prefetch window's worth, held alongside the decoded collection. The decode accumulator is pre-sized from per-partition row_count metadata, saturated and clamped to a fixed upper bound so untrusted values cannot turn the reservation into a panic or OOM. The prefetch window is refilled only after each fold step so a decode error short-circuits without issuing further fetches.
yuly3
marked this pull request as ready for review
July 4, 2026 10:47
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.