refactor(schema): replace ColumnIndex newtype with plain usize - #196
Merged
Conversation
The ColumnIndex newtype required a round-trip through the schema to obtain, yet provided no validity guarantee: accessors still had to bounds-check and return errors. Column positions in the public API are now plain usize, enabling literal positional access like value_at(0). Schema::from_columns loses its u32-capacity check, which only guarded the ColumnIndex(u32) representation, and becomes infallible.
Exercises the dynamic typing path against a local mock server: schema inspection, CellValue variant matching, access by name and by index, take/take_at, and into_json_object conversion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.