Add request ID to MFA password logins - #202
Merged
Merged
Conversation
yuly3
self-requested a review
July 17, 2026 17:52
Collaborator
|
Thanks for looking into the failing CI. The red integration tests are caused by the workflow not receiving repository secrets for fork-based pull requests, not by the changes in this PR. Please revert the CI-related changes and restore the branch to commit: 16564f9 Once the PR is back to that state, I’ll approve and merge it. We can address the CI workflow separately. |
Contributor
Author
yuly3
approved these changes
Jul 17, 2026
yuly3
left a comment
yuly3
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for reverting the CI changes. The PR looks good to me. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snowflake TOTP logins require a
request_idquery parameter. Password MFA credentials currently omit it, causing valid passcodes to be rejected asTOTP Invalid.This adds a request ID when a password credential carries either passcode mode, while preserving existing plain-password behavior.
Verified with unit tests and a live Snowflake TOTP account.