Skip to content

network: transaction: request memory content in traces#1585

Open
istankovic wants to merge 1 commit intoeth-brownie:masterfrom
istankovic:trace-memory
Open

network: transaction: request memory content in traces#1585
istankovic wants to merge 1 commit intoeth-brownie:masterfrom
istankovic:trace-memory

Conversation

@istankovic
Copy link
Copy Markdown
Contributor

geth will not return memory content unless enableMemory is set to true,
which will cause _get_memory to fail.

This can be reproduced by provoking a typed error in a contract inside brownie console running with a local
geth-dev instance.

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

geth will not return memory content unless enableMemory is set to true,
which will cause _get_memory to fail.
@istankovic
Copy link
Copy Markdown
Contributor Author

Could someone please rerun the CI? It seems like the tests are flaky.

@czepluch
Copy link
Copy Markdown

Bump!

@istankovic
Copy link
Copy Markdown
Contributor Author

Another bump.

@istankovic
Copy link
Copy Markdown
Contributor Author

And another.

ammaraskar added a commit to sslab-gatech/blockchain-lab-pwneth that referenced this pull request Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants