Open
Conversation
Currently, running `brownie run scripts/deploy.py` fails when the path to the project has a `.` in it. The following path ``` /Users/john.doe/Projects/Chainlink ``` Gets converted to ``` Users.john.doe.Projects.Chainlink ``` Which fails because it thinks that `john` and `doe` are two directories. Using the above method fixes this error.
Collaborator
|
@otis01 could you add some tests for this? I'd be happy to merge with those added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, running
brownie run scripts/deploy.pyfails when the path to the project has a.in it.The following path
Gets converted to
Which fails because it thinks that
johnanddoeare two directories. Using the above method fixes this error.What I did
Add an import_module script that works regardless of the path.
How I did it
Using "/" instead if "." in the path string.
How to verify it
Run it locally in a path that has a
.in it.Checklist