Skip to content

Green contexts and inter_sm scripts#3

Merged
elvingerpaul merged 23 commits into
benchmarkingfrom
benchmarking_inter
Jun 25, 2025
Merged

Green contexts and inter_sm scripts#3
elvingerpaul merged 23 commits into
benchmarkingfrom
benchmarking_inter

Conversation

@fotstrt

@fotstrt fotstrt commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

This PR:

  • Introduces Green contexts and creation of streams associated with contexts
  • Adds inter-sm interference scripts
  • Unifies the gpu_model_runner.py for both intra- and inter-sm interference

@github-actions

Copy link
Copy Markdown

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@fotstrt fotstrt changed the base branch from main to benchmarking June 24, 2025 08:05
@fotstrt fotstrt requested a review from elvingerpaul June 24, 2025 08:05

@elvingerpaul elvingerpaul left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, thank you! Mostly about making sure that main.py is consistent with gcontext_test.py. I'm re-running the measurements to check that they overlap with the previous config. Once they match I'll approve the PR :)

One question, is there a specific reason why we don't unify the behavior in having one single interference kernel for the entire decode for inter_sm and intra_sm instead of launching a new decode kernel for each token in the intra_sm case?

Comment thread inter_sm/gcontext_test.py Outdated
Comment thread inter_sm/gcontext_test.py Outdated
Comment thread vllm/interference/interference_kernels.cu
Comment thread vllm/v1/worker/gpu_model_runner.py Outdated
Comment thread vllm/v1/worker/gpu_model_runner.py Outdated
Comment thread vllm/v1/worker/gpu_model_runner.py
@elvingerpaul elvingerpaul self-requested a review June 25, 2025 10:32

@elvingerpaul elvingerpaul left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge the PR, so that I can add code and have all in one place

@elvingerpaul elvingerpaul merged commit b46737c into benchmarking Jun 25, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants