Green contexts and inter_sm scripts#3
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
…el in isolation or intra_sm) synchronize on entire GPU
elvingerpaul
left a comment
There was a problem hiding this comment.
Looking good, thank you! Mostly about making sure that main.py is consistent with gcontext_test.py. I'm re-running the measurements to check that they overlap with the previous config. Once they match I'll approve the PR :)
One question, is there a specific reason why we don't unify the behavior in having one single interference kernel for the entire decode for inter_sm and intra_sm instead of launching a new decode kernel for each token in the intra_sm case?
elvingerpaul
left a comment
There was a problem hiding this comment.
I'll merge the PR, so that I can add code and have all in one place
This PR: