Skip to content

Embed payload_status into head fork choice check#5250

Merged
brech1 merged 3 commits into
ethereum:masterfrom
brech1:fix/head-payload-status-check
May 29, 2026
Merged

Embed payload_status into head fork choice check#5250
brech1 merged 3 commits into
ethereum:masterfrom
brech1:fix/head-payload-status-check

Conversation

@brech1

@brech1 brech1 commented May 13, 2026

Copy link
Copy Markdown
Member

Description

This PR implements an @mkalinin suggestion, to embed the payload_status into the head fork choice checks. This can be justified to follow the updated

class ForkChoiceNode(Container):
    root: Root
    payload_status: PayloadStatus

Discussion on this topic can be found on discord:

This should probably be revisited after #5249

@github-actions github-actions Bot added the testing CI, actions, tests, testing infra label May 13, 2026

@mkalinin mkalinin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for one thing, this looks good to me! 👍

Comment thread tests/generators/compliance_runners/fork_choice/runner/test_run.py
@brech1 brech1 force-pushed the fix/head-payload-status-check branch from 9894f09 to 1f93a8c Compare May 28, 2026 12:06
@brech1 brech1 marked this pull request as ready for review May 28, 2026 12:21
@brech1 brech1 requested a review from mkalinin May 28, 2026 12:21
@mkalinin

Copy link
Copy Markdown
Contributor

@ericsson49 could you please take a look at this PR

@ericsson49 ericsson49 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brech1 brech1 enabled auto-merge (squash) May 29, 2026 10:19
@brech1 brech1 merged commit bd994d2 into ethereum:master May 29, 2026
15 checks passed
@brech1 brech1 deleted the fix/head-payload-status-check branch June 10, 2026 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing CI, actions, tests, testing infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants