Embed payload_status into head fork choice check#5250
Merged
Conversation
mkalinin
approved these changes
May 14, 2026
mkalinin
left a comment
Contributor
There was a problem hiding this comment.
Except for one thing, this looks good to me! 👍
9894f09 to
1f93a8c
Compare
Contributor
|
@ericsson49 could you please take a look at this PR |
mkalinin
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements an @mkalinin suggestion, to embed the
payload_statusinto theheadfork choice checks. This can be justified to follow the updatedDiscussion on this topic can be found on discord:
This should probably be revisited after #5249