Precompute head for update_proposer_boost_root#5300
Merged
Conversation
jtraglia
changed the title
update_proposer_boost_root
potuz
reviewed
May 27, 2026
potuz
left a comment
potuz
left a comment
Contributor
There was a problem hiding this comment.
I would also add the dependent root path to this PR, but it looks good to me anyway.
Member
We can handle this in another PR. |
jtraglia
pushed a commit
that referenced
this pull request
Jun 1, 2026
Follow up to #5300. Switches from `proposer_index` to `dependent_root` check when applying proposer boost. There is an edge case where `proposer_index` is the same on the two competing chains with different dependent roots, in this case applying PB to the diverged chain can be exploited. This PR is a fix for that edge case. There are two ways how `dependent_root` can be computed: 1) with the block tree, root and store time 2) with the post-state of a block. (1) since we do this computation in the FC context.
This was referenced Jun 1, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5286 by computing the head before the block is added to the Store.
Depends on #5249