Fix sidebar positioning#828
Open
zcstarr wants to merge 3 commits into
Open
Conversation
Remove Pages deployment from release.yaml so deploy.yaml is the only writer. After github-release attaches assets, trigger-deploy dispatches deploy.yaml on main. This eliminates the race where release (tag checkout) and main deploy could queue on the same pages concurrency group and leave /next pointing at stale tagged content. Release docs build now runs assemble-versions.js (build:docs:ci:release) so the snapshot tarball includes the full versioned docs tree. Which previously lead to missing version dropdown, before merging release notes.
This change reorders the sidebar positions to respect full semver path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sidebar didn't respect prerelease ordering, this change introduces a pre release ordering for the sidebar. Just noting here that this PR is stacked (#827) which allows me to have tested this change with the refactored workflows.