refactor(tests): Enhance heavy ported tests#2623
refactor(tests): Enhance heavy ported tests#2623marioevz merged 12 commits intoethereum:forks/amsterdamfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2623 +/- ##
================================================
Coverage 86.24% 86.24%
================================================
Files 599 599
Lines 36984 36984
Branches 3795 3795
================================================
Hits 31895 31895
Misses 4525 4525
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@marioevz I feel that if we do this, we are going to lose the opportunity to do the last step of the automatic porting to eliminate the hardcoded addresses. I created this PR: #2535 that is in need of review, to be able to do the step of doing that by comparing traces. I think it would be a good idea to discuss if we want to compare the traces by ignoring the stack or we can have access to the immediate values that are currently not in the trace. |
This reverts commit 3b850b6.
8a55e68 to
71046f9
Compare
|
I've condensed the
Commit 3b850b6 can be verified using |
|
cc @spencer-tb I believe this change is necessary because otherwise it would be a pain to verify what happens in each different file and test case for 8037. |
spencer-tb
left a comment
There was a problem hiding this comment.
LGTM! Just want to confirm the valid from changes were intentional :)
If so feel free to merge!
🗒️ Description
Manually enhance some of the heaviest python ported tests in
tests/ported_static, by programatically generating the bytecode contained in them instead of hard-coding them.Removes ~322k lines of python code.
@leolara I've added:
To the docstring in the header of each test, so we can check for
@manually-enhancedto skip these tests when running the script again, wdyt? cc @spencer-tb🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture