feat(tests-execute): EOA pkey support for stub account#2624
Merged
LouisTsai-Csie merged 10 commits intoethereum:forks/amsterdamfrom Apr 8, 2026
Merged
feat(tests-execute): EOA pkey support for stub account#2624LouisTsai-Csie merged 10 commits intoethereum:forks/amsterdamfrom
EOA pkey support for stub account#2624LouisTsai-Csie merged 10 commits intoethereum:forks/amsterdamfrom
Conversation
7 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2624 +/- ##
================================================
Coverage 86.24% 86.24%
================================================
Files 599 599
Lines 36984 36984
Branches 3795 3795
================================================
Hits 31895 31895
Misses 4525 4525
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marioevz
reviewed
Apr 6, 2026
Member
marioevz
left a comment
There was a problem hiding this comment.
Some comments, mainly cleaning up a bit of technical debt surrounding this feature.
packages/testing/src/execution_testing/benchmark/stub_config.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/benchmark/stub_config.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/benchmark/tests/test_stub_config.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/cli/pytest_commands/plugins/shared/address_stubs.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/cli/pytest_commands/plugins/shared/address_stubs.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/cli/pytest_commands/plugins/shared/address_stubs.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/cli/pytest_commands/plugins/shared/address_stubs.py
Outdated
Show resolved
Hide resolved
packages/testing/src/execution_testing/cli/pytest_commands/plugins/shared/address_stubs.py
Outdated
Show resolved
Hide resolved
d9a3070 to
602d57c
Compare
marioevz
approved these changes
Apr 7, 2026
Member
marioevz
left a comment
There was a problem hiding this comment.
LGTM, much better, thanks for the changes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Originally, the stub file account only supported contracts, so we only provide contract addresses to the stub file. This becomes a problem when we want to do EIP-7702 interaction on-chain, which requires providing the private key of an EOA.
In the previous PR, we embed the private key in the test, which led to RPC issues (see PR #2617 ). This PR refactors everything into the stub account.
Add private key (
pkey) support to stub configuration, enabling EOA stubs for benchmark tests that need tx signing (e.g., EIP-7702 authorization lists).Stub file format change: entries are now objects with mandatory addr and optional pkey:
{ "contract_stub": {"addr": "0x..."}, "eoa_stub": {"addr": "0x...", "pkey": "0x..."} }When pkey is provided, the derived address is validated against addr at parse time.
🔗 Related Issues or PRs
PR #2617
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture