✨ feat(test): EIP-7928 Selfdestruct a dirty account#2967
Open
raxhvl wants to merge 9 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2967 +/- ##
================================================
Coverage 90.52% 90.53%
================================================
Files 535 535
Lines 32893 32893
Branches 3021 3021
================================================
+ Hits 29778 29780 +2
+ Misses 2596 2595 -1
+ Partials 519 518 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
marioevz
reviewed
Jun 9, 2026
marioevz
left a comment
Member
There was a problem hiding this comment.
Looks mostly good to me. A couple of comments and a suggestion to add an extra case. Thanks!
Member
Author
|
Thanks for the review. I have added a revert case to test if the dirty changes shows up in BAL 6e4ce7d |
dce7ae4 to
5fde0ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
What are we testing?
An account selfdestructed in the same transaction it was created is ephemeral. Any state changes (nonce, storage, balance, code) made to this account is discarded and MUST not leak into BAL.
🔗 Related Issues or PRs
closes #2920 h/t @jangko
✅ Checklist
just statictype(scope):.