Skip to content

✨ feat(test): EIP-7928 Selfdestruct a dirty account#2967

Open
raxhvl wants to merge 9 commits into
ethereum:forks/amsterdamfrom
raxhvl:feat/bal-selfdestruct-dirty-account
Open

✨ feat(test): EIP-7928 Selfdestruct a dirty account#2967
raxhvl wants to merge 9 commits into
ethereum:forks/amsterdamfrom
raxhvl:feat/bal-selfdestruct-dirty-account

Conversation

@raxhvl

@raxhvl raxhvl commented Jun 9, 2026

Copy link
Copy Markdown
Member

🗒️ Description

What are we testing?

An account selfdestructed in the same transaction it was created is ephemeral. Any state changes (nonce, storage, balance, code) made to this account is discarded and MUST not leak into BAL.

🔗 Related Issues or PRs

closes #2920 h/t @jangko

✅ Checklist

@raxhvl raxhvl self-assigned this Jun 9, 2026
@raxhvl raxhvl added the C-test Category: test label Jun 9, 2026
@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.53%. Comparing base (5f132e7) to head (945c184).
⚠️ Report is 5 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2967   +/-   ##
================================================
  Coverage            90.52%   90.53%           
================================================
  Files                  535      535           
  Lines                32893    32893           
  Branches              3021     3021           
================================================
+ Hits                 29778    29780    +2     
+ Misses                2596     2595    -1     
+ Partials               519      518    -1     
Flag Coverage Δ
unittests 90.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raxhvl raxhvl marked this pull request as ready for review June 9, 2026 14:52

@marioevz marioevz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me. A couple of comments and a suggestion to add an extra case. Thanks!

@raxhvl

raxhvl commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

Thanks for the review. I have added a revert case to test if the dirty changes shows up in BAL 6e4ce7d

@raxhvl raxhvl requested a review from marioevz June 9, 2026 20:15
raxhvl and others added 8 commits June 10, 2026 12:29
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
Co-authored-by: Mario Vega <marioevz@gmail.com>
@raxhvl raxhvl force-pushed the feat/bal-selfdestruct-dirty-account branch from dce7ae4 to 5fde0ad Compare June 10, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-test Category: test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing BAL test cases related to EIP-6780 self destruct

2 participants