rpc: add a rpc.rangelimit flag#33163
Merged
Merged
Conversation
MqllR
force-pushed
the
filter_rangelimit
branch
from
ee7f6d3 to
978d841
Compare
jrhea
reviewed
Nov 26, 2025
| backend.startFilterMaps(0, false, filtermaps.DefaultParams) | ||
| defer backend.stopFilterMaps() | ||
|
|
||
| // Set rangeLimit to 5, but request 10 blocks |
Contributor
There was a problem hiding this comment.
This comment refers to [0,9] as 10 blocks, but the implementation enforces the limit on end - begin (9 in this case). Might be worth clarifying this so it’s clear the limit applies to end - begin, not the inclusive block count.
jrhea
reviewed
Nov 26, 2025
| } | ||
| RPCGlobalRangeLimitFlag = &cli.Uint64Flag{ | ||
| Name: "rpc.rangelimit", | ||
| Usage: "Maximum block range allowed for range queries (0 = unlimited)", |
Contributor
There was a problem hiding this comment.
Maybe clarify that this limit applies to (end - begin), since block range can be interpreted as an inclusive count.
Contributor
Author
There was a problem hiding this comment.
Simply added the (end - begin) information but if you have a better description or find it still unclear, let me know :)
Contributor
|
@MqllR are you still working on this? please address the review comments. |
Contributor
Author
Contributor
Author
MariusVanDerWijden
changed the title
MariusVanDerWijden
previously approved these changes
Jan 17, 2026
MariusVanDerWijden
force-pushed
the
filter_rangelimit
branch
from
785b551 to
63e9f85
Compare
MariusVanDerWijden
approved these changes
Jan 17, 2026
Closed
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 17, 2026
19 tasks
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 19, 2026
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 20, 2026
gzliudan
added a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 29, 2026
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jan 29, 2026
Merged
18 tasks
gballet
pushed a commit
to BZO95/go-ethereum
that referenced
this pull request
May 21, 2026
Adding an RPC flag to limit the block range size for eth_getLogs and eth_newFilter requests. closing ethereum#24508 --------- Co-authored-by: MariusVanDerWijden <m.vanderwijden@live.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an RPC flag to limit the block range size for eth_getLogs and eth_newFilter requests.
closing #24508