core/types: fix panic on invalid signature length#33647
Merged
Conversation
gballet
approved these changes
Jan 21, 2026
gzliudan
pushed a commit
to gzliudan/XDPoSChain
that referenced
this pull request
Jan 23, 2026
Replace panic with error return in decodeSignature to prevent crashes on invalid inputs, and update callers to propagate the error.
19 tasks
AnilChinchawale
pushed a commit
to XinFinOrg/XDPoSChain
that referenced
this pull request
Jan 27, 2026
Replace panic with error return in decodeSignature to prevent crashes on invalid inputs, and update callers to propagate the error. Co-authored-by: DeFi Junkie <deffie.jnkiee@gmail.com>
gballet
pushed a commit
to BZO95/go-ethereum
that referenced
this pull request
May 21, 2026
Replace panic with error return in decodeSignature to prevent crashes on invalid inputs, and update callers to propagate the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace panic with error return in decodeSignature to prevent crashes on invalid inputs, and update callers to propagate the error.