Skip to content

.github/workflows: activate freebsd build on PRs#34717

Closed
gballet wants to merge 1 commit into
masterfrom
freebsd-on-prs
Closed

.github/workflows: activate freebsd build on PRs#34717
gballet wants to merge 1 commit into
masterfrom
freebsd-on-prs

Conversation

@gballet

@gballet gballet commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gballet gballet added this to the 1.17.3 milestone Apr 14, 2026
@fjl

fjl commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Build failed in hidapi

@gballet

gballet commented Apr 14, 2026

Copy link
Copy Markdown
Collaborator Author

This isn't the same error as the one that was reported in that issue though. actually it is, I thought it was a library thing but it's an include thing.

So I dug in a little, and the thing is that the ports build uses the ports version of the library. This is why the fix proposed by Enrique works for building ports. As such, the fix proposed in #34632 is wrong, as ports and system might have a different version of the headers.

@s1na

s1na commented Apr 23, 2026

Copy link
Copy Markdown
Contributor

I'd recommend a way to cancel a job if there were subsequent commits to the same PR. Otherwise it will just enqueue multiple (most of which is obsolete) jobs.

  concurrency:
    group: freebsd-${{ github.workflow }}-${{ github.ref }}
    cancel-in-progress: true

@fjl

fjl commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Please ensure we don't use external GH actions repository for launching the VM, i.e. fork it to your own account or the ethereum org, and make sure all JS dependencies are pinned.

@fjl fjl dismissed MariusVanDerWijden’s stale review April 29, 2026 14:14

We should only activate this when we are sure the external action is safe.

@fjl fjl removed this from the 1.17.3 milestone May 7, 2026
@gballet gballet closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants