eth/protocols/snap: purge stale sync state when snap sync v2 is re-enabled#35316
Open
jrhea wants to merge 3 commits into
Open
eth/protocols/snap: purge stale sync state when snap sync v2 is re-enabled#35316jrhea wants to merge 3 commits into
jrhea wants to merge 3 commits into
Conversation
jrhea
changed the title
Member
|
I am curious in which case the snap sync will be re-enabled on top of a synced node. As the defensive mechanism, I am fine with it. |
| // isPivotCommitted reports whether the head block has caught up to the | ||
| // pivot. That only happens when a completed sync committed the pivot block | ||
| // as the new chain head. | ||
| func isPivotCommitted(db ethdb.Database, pivot *types.Header) bool { |
Member
There was a problem hiding this comment.
Shall we consider the Pivot block is canonical or not?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If snap sync v2 is re-enabled after a previous sync already completed and committed its pivot, the leftover journal is now discarded instead of resumed.