core/rawdb: drop stray %d verb from freezer metadata log message#35351
Merged
Conversation
log.Error takes a plain message plus structured key/value pairs, not a printf format string, so the %d in the flushOffset error message was never substituted and printed literally. The offset value is already emitted through the "offset" field, so remove the leftover verb from the message text.
rjl493456442
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The error logged when a freezer table metadata carries an out-of-range
flushOffsetincludes a%dverb in its message:log.Errortakes a plain message followed by structured key/value pairs, not a printf format string, so the%dis never substituted and is printed verbatim. The offset is already emitted through theoffsetfield, making the verb both non-functional and redundant.Before:
After:
This drops the leftover verb from the message text; the offset value is unchanged and still shown via the
offsetfield.