Skip to content

Add clean_proto helper script#5

Open
pilz wants to merge 1 commit into
mainfrom
api/clean-proto
Open

Add clean_proto helper script#5
pilz wants to merge 1 commit into
mainfrom
api/clean-proto

Conversation

@pilz

@pilz pilz commented Aug 8, 2025

Copy link
Copy Markdown
Member

No description provided.

@ale-rt ale-rt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to me this is actually something you should have in proto... Sorry.

I can even accept this, but please check my notes

Comment thread scripts/clean_proto.py
for lang, value in translations.items():
if lang != 'en' and value == en_value:
print(f'Check {key}: {lang} == {en_value}')
breakpoint()

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm... Leftover?

Comment thread scripts/clean_proto.py
@@ -0,0 +1,50 @@
import yaml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name clean_proto is not clear to me.
I tried with Chat GPT it suggests me check_redundant_translations
It looks like we are missing a shebang line and yaml is not in the standard library.

Comment thread scripts/clean_proto.py

# # Write it back (optional)
# with open(yaml_path, 'w', encoding='utf-8') as f:
# yaml.dump(data, f, allow_unicode=True, sort_keys=False)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove commented code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants