This repository was archived by the owner on Apr 15, 2024. It is now read-only.
Fixed issue when a compressed font is too big for the default sized zlib buffer#246
Open
adamestein wants to merge 3 commits intoeuske:masterfrom
Open
Fixed issue when a compressed font is too big for the default sized zlib buffer#246adamestein wants to merge 3 commits intoeuske:masterfrom
adamestein wants to merge 3 commits intoeuske:masterfrom
Conversation
…en with an odd length code to decode which causes unpack() to have an error. If unpack() fails for any reason, just return an empty tuple as if there were no data to unpack.
o Fixed issue where a PDF comment goes to end of line so matching fails. When fixed, the old problem of having an odd length code to decode comes back causing unpack() to have a problem. This is fixed by returning an empty tuple as if there was no data to unpack. o Fixed issue when a compressed font is too big for the default sized zlib buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are PDF files where an embedded font is so large that zlib runs out of default-sized buffer space when decompressing. The zlib module does have a way to not worry about the buffer size (and so the size of the font). This patch fixes the decompression so that it doesn't matter the amount of font data.