feat: add CSS @property - #4314
Draft
yisibl wants to merge 1 commit into
Draft
Conversation
yisibl
force-pushed
the
add-css-at-property
branch
from
October 31, 2025 04:18
b0a447a to
f43d4b1
Compare
evanw
approved these changes
Nov 1, 2025
evanw
left a comment
evanw
left a comment
Owner
There was a problem hiding this comment.
This looks great. Thanks for sending this and for adding tests.
yisibl
commented
Nov 3, 2025
| syntax: "<length> | <percentage>"; | ||
| inherits: true; | ||
| initial-value: 90.6%; | ||
| }`, "@property --❤️{syntax:\"<length> | <percentage>\";inherits:true;initial-value:90.6%}", "") |
Contributor
Author
There was a problem hiding this comment.
@evanw I'd like to further reduce whitespace here([syntax](syntax: "<length> | <percentage>";)). Is this handled in internal/css_parser/css_decls.go?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/@property