fix: accept forecast arrays in widget decoder - #225
Merged
Conversation
4 tasks
5 tasks
Member
|
@naltatis can we merge this? Should support both formats. |
Member
Author
|
Verified both versions working on iOS devices. |
Member
|
Why is this even relevant for the app? Because it displays the forecast in its widget? |
Member
Author
|
Yes. The widgets call the API directly. You cant run a browser there. Widget-runtime is quite restricted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pairs with evcc-io/evcc#32391, replaces the format from evcc-io/evcc#31765
evcc is switching the forecast payload from
{start, end, value}objects with RFC3339 strings to[start, end, value]arrays with unix seconds, and the solar timeseries from{ts, val}to[ts, val]. The widget decoder now accepts both, so widgets keep working across old and new evcc versions.ForecastSlotandSolarPointdecode from an unkeyed container first, falling back to the keyed object form🤖 Generated with Claude Code