Skip to content

chore: Typescript: Rewrite Savings#21019

Merged
naltatis merged 5 commits into
evcc-io:masterfrom
Maschga:tsc/savings
May 15, 2025
Merged

chore: Typescript: Rewrite Savings#21019
naltatis merged 5 commits into
evcc-io:masterfrom
Maschga:tsc/savings

Conversation

@Maschga

@Maschga Maschga commented May 3, 2025

Copy link
Copy Markdown
Collaborator
  • ✍️ rewrite Savings folder to Typescript

TODO:

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Maschga - I've reviewed your changes - here's some feedback:

  • Consider defining dedicated interfaces for API responses instead of using inline casting with as for improved type safety and maintainability.
  • Consider consistently using PropType for defining component props, even for basic types like String or Boolean, for better clarity.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig added the infrastructure Basic functionality label May 4, 2025
@naltatis naltatis self-assigned this May 5, 2025
@Maschga Maschga changed the title Chore: Typescript: Rewrite Savings chore: Typescript: Rewrite Savings May 5, 2025
@github-actions github-actions Bot added the stale Outdated and ready to close label May 12, 2025
@github-actions github-actions Bot removed the stale Outdated and ready to close label May 14, 2025
@naltatis naltatis merged commit 8f114dc into evcc-io:master May 15, 2025
7 checks passed
@Maschga Maschga deleted the tsc/savings branch May 16, 2025 06:26
guido4096 pushed a commit to guido4096/evcc that referenced this pull request May 25, 2025
Co-authored-by: Michael Geers <michael@geers.tv>
StarF666 pushed a commit to StarF666/evcc that referenced this pull request Oct 1, 2025
Co-authored-by: Michael Geers <michael@geers.tv>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Basic functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants