chore: remove deprecated VW, Audi, Cupra and Seat vehicle implementations#30549
Merged
Conversation
The vw and audi vehicle types and their weconnect-based API have been superseded by drivesomethinggreater, which the vw and audi templates now render to. Remove the unused implementations and the VAG packages (weconnect, audi, idkproxy, aazsproxy, cariad, service/azs) that only served them. Shared packages (vag/vwidentity, vag/service/mbb, vw root provider) are retained for seat, cupra and skoda.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
The cupra template now renders to drivesomethinggreater (EU Data Act), matching the vw and audi templates. This removes the native cupra vehicle type along with the now-unused cupra provider, API and types. The cupra OAuth2 config is retained as it is still used by the seat implementation.
andig
changed the title
The seat template now renders to drivesomethinggreater (EU Data Act), matching vw, audi and cupra. This removes the native seat vehicle type along with the weconnect-era packages that only served it: the vehicle/seat tree (including the shared cupra OAuth2 config), the vehicle/vw weconnect provider, vehicle/vag/service and vehicle/vag/mbb. vehicle/vag/vwidentity is retained as it is still used by skoda and the drivesomethinggreater backend.
andig
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vw, audi, cupra and seat vehicle types and their weconnect-based API have been superseded by drivesomethinggreater, which the vw, audi, cupra and seat templates now render to. This removes the unused implementations along with the VAG packages that only served them.
The cupra and seat templates keep their
cupra/seattemplate names (so existing configs stay valid) but now render to drivesomethinggreater with the respective brand, mirroring vw and audi.Removed:
Retained because still used by skoda and the drivesomethinggreater backend:
go build, vet, vehicle and template tests and golangci-lint all pass.