Skip to content

DriveSomethingGreater: log data point id before name#31202

Merged
andig merged 1 commit into
masterfrom
chore/dsg-log-point-id
Jun 25, 2026
Merged

DriveSomethingGreater: log data point id before name#31202
andig merged 1 commit into
masterfrom
chore/dsg-log-point-id

Conversation

@andig

@andig andig commented Jun 25, 2026

Copy link
Copy Markdown
Member

The eu-data-act store's debug log printed only the map index per data point. This logs the point's unique GUID (id) before its delivered field name, so points are identifiable in traces (recv <id> <name>: <value> (<timestamp>)).

point now carries its Key (id) and Name; populated in points(), used in logData.

🤖 Generated with Claude Code

@andig andig added the vehicles Specific vehicle support label Jun 25, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The point struct now duplicates the data field name both as the map key and as Name; consider whether you can rely on the existing map key instead of storing Name to avoid redundancy and potential divergence if they ever get out of sync.
  • Given logData now uses p.Key and p.Name, it might be safer to explicitly document or enforce that points() is the only constructor for point, or add a small helper constructor, so these fields are always populated consistently.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `point` struct now duplicates the data field name both as the map key and as `Name`; consider whether you can rely on the existing map key instead of storing `Name` to avoid redundancy and potential divergence if they ever get out of sync.
- Given `logData` now uses `p.Key` and `p.Name`, it might be safer to explicitly document or enforce that `points()` is the only constructor for `point`, or add a small helper constructor, so these fields are always populated consistently.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig enabled auto-merge (squash) June 25, 2026 09:15
@andig andig merged commit 0d010f6 into master Jun 25, 2026
16 checks passed
@andig andig deleted the chore/dsg-log-point-id branch June 25, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vehicles Specific vehicle support

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant