DriveSomethingGreater: log data point id before name#31202
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
pointstruct now duplicates the data field name both as the map key and asName; consider whether you can rely on the existing map key instead of storingNameto avoid redundancy and potential divergence if they ever get out of sync. - Given
logDatanow usesp.Keyandp.Name, it might be safer to explicitly document or enforce thatpoints()is the only constructor forpoint, or add a small helper constructor, so these fields are always populated consistently.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `point` struct now duplicates the data field name both as the map key and as `Name`; consider whether you can rely on the existing map key instead of storing `Name` to avoid redundancy and potential divergence if they ever get out of sync.
- Given `logData` now uses `p.Key` and `p.Name`, it might be safer to explicitly document or enforce that `points()` is the only constructor for `point`, or add a small helper constructor, so these fields are always populated consistently.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eu-data-act store's debug log printed only the map index per data point. This logs the point's unique GUID (id) before its delivered field name, so points are identifiable in traces (
recv <id> <name>: <value> (<timestamp>)).pointnow carries itsKey(id) andName; populated inpoints(), used inlogData.🤖 Generated with Claude Code