fix(rct): hold battery at current SoC instead of MaxSoc, disable grid charging#31293
Closed
Maschga wants to merge 1 commit into
Closed
fix(rct): hold battery at current SoC instead of MaxSoc, disable grid charging#31293Maschga wants to merge 1 commit into
Maschga wants to merge 1 commit into
Conversation
… charging In BatteryHold mode, writing BatterySoCTargetMin = MaxSoc with strategy Internal causes the inverter to charge the battery from the grid towards MaxSoc when power_mng.use_grid_power_enable is true. Instead, read the current SoC and use it as both min and max target so the inverter has no incentive to charge or discharge. Also explicitly disable use_grid_power_enable in BatteryHold and BatteryNormal so the flag set by BatteryCharge doesn't persist and cause unintended grid charging in subsequent modes. Fixes #31280 Co-authored-by: andig <andig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #31280