Modbus: don't guard connection settings with the registry mutex - #32695
Merged
Conversation
unregisterConnection closes the physical connection while holding the registry mutex. Reading the delay before each register access took the same mutex, so closing one connection could block requests on all other connections.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
andig
commented
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32694.
The shared delay, connect delay and timeout added in #32694 were guarded by the connection registry mutex. That mutex is held while a physical connection is closed, so unregistering one connection could block register access on every other modbus connection. They now use a dedicated mutex per physical connection.
🤖 Generated with Claude Code