Sungrow: add caveat for coarse energy resolution - #32743
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Double-check the YAML indentation of the
caveatsblock — as written it appears nested under the first product entry rather than at the template level, which may prevent it from being applied as intended.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Double-check the YAML indentation of the `caveats` block — as written it appears nested under the first product entry rather than at the template level, which may prevent it from being applied as intended.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Instead of caveat we should just remove it as we did for other templates. Or revert all those? |
Thats a tradeoff discussion: long-term accuracy vs. short-term resolution. In context of upcoming month/years statistics having meter-based values is definitely more solid and will avoid discrepancies with our data and the vendors app.
Not sure what our minimum accuracy threshold was in the past. But yes, having this consistent thought all meters of a class would help. |
It is. But whatever we do should be consistent. This is a new approach. |
|
We could use the decimal part of register 5002 (0.1 kWh, UINT16, Daily power yields) to raise the resolution of 5003-5004. |
|
This would require testing if .0 aligns with the coarse counter wrap-around. |
relates to #32711
The SG series inverter reports total PV yield (register 5003) in whole 1 kWh steps, so 15-minute energy history advances in coarse chunks. This is a hardware register limitation, not something evcc can smooth out. Document it as a template caveat.
sungrow-invertertemplate🤖 Generated with Claude Code