OCPP: keep websocket alive between heartbeats - #33099
Merged
Merged
Conversation
fixes #32236 The websocket server used the ocpp-go default PingWait of 60s while BootNotification requests a 60s heartbeat interval. Chargers that don't send websocket pings therefore raced the read deadline and were disconnected whenever heartbeat and meter values coincided.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
This comment has been minimized.
This comment has been minimized.
sourcery-ai
Bot
dismissed
their stale review
August 23, 2026 09:13
Sourcery withdrew this approval because the latest commits introduced blocking findings.
premultiply
approved these changes
Aug 23, 2026
Contributor
|
✅ Opened backport pull request on |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #32236
The websocket server used the ocpp-go default
PingWaitof 60s whileBootNotificationrequests a 60s heartbeat interval. Every received frame resets the read deadline, so an idle charger that does not send websocket pings has to deliver its heartbeat within exactly one deadline period.Trace from the issue (MENNEKES AMTRON 4You, idle, heartbeat and clock-aligned meter values both at 60s and landing in the same second):
All 17 disconnects in the trace occur exactly 60s after the last received message, i.e. the central system closes the connection, not the charger.
Heartbeat interval and websocket timeout are now derived from one constant, with
PingWaitat three heartbeats.🤖 Generated with Claude Code