Fix svgPath issue for paths with spacing#54
Open
fpunny wants to merge 1 commit intoevenchange4:masterfrom
Open
Fix svgPath issue for paths with spacing#54fpunny wants to merge 1 commit intoevenchange4:masterfrom
fpunny wants to merge 1 commit intoevenchange4:masterfrom
Conversation
Currently when a svgPath has a space (for example, `C://owo/John Doe`). The command is executed as `svgr C://owo/John Doe ...`, resulting in the file not being found since it believes the location is "C://owo/John". Hence, having double quotes to preserve the spaces in the path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently when a svgPath has a space (for example,
C://owo/John Doe). The command is executed assvgr C://owo/John Doe ..., resulting in the file not being found since it believes the location isC://owo/John. Hence, having double quotes around the svgPath would preserve the spaces