Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

feat([openapi]): if service version is lower than latest add a servi…#29

Open
XaaXaaX wants to merge 1 commit intoevent-catalog:mainfrom
XaaXaaX:feat/verify-current-version-vs-latest
Open

feat([openapi]): if service version is lower than latest add a servi…#29
XaaXaaX wants to merge 1 commit intoevent-catalog:mainfrom
XaaXaaX:feat/verify-current-version-vs-latest

Conversation

@XaaXaaX
Copy link
Copy Markdown

@XaaXaaX XaaXaaX commented Oct 20, 2024

Motivation

When service version lower than latest are treated after latest is already treated this leads to versioning the latest in versioned and keep the incorrect version as latest.

example:
if a sepc for version 2 is treated and later the version 1 is treated the latest version will be the v1 and v2 get into the versiones folder.

This pulrequest check the sequence of versions and treat them in correct order

@XaaXaaX XaaXaaX requested a review from boyney123 as a code owner October 20, 2024 01:11
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 20, 2024

⚠️ No Changeset found

Latest commit: 0b835db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@XaaXaaX XaaXaaX force-pushed the feat/verify-current-version-vs-latest branch 3 times, most recently from 1ffa5ee to 1aee346 Compare October 20, 2024 22:30
@XaaXaaX
Copy link
Copy Markdown
Author

XaaXaaX commented Oct 20, 2024

This PR relates to SDK PR event-catalog/sdk#44
By this we will remove hard coded versioned service path here

@XaaXaaX XaaXaaX changed the title Feat/verify current version vs latest feat([openapi]): if service version is lower than latest add a servi… Oct 21, 2024
@XaaXaaX XaaXaaX force-pushed the feat/verify-current-version-vs-latest branch 2 times, most recently from 4133cfa to 6085f46 Compare October 22, 2024 23:01
…test add a service version in versioned folder
@XaaXaaX XaaXaaX force-pushed the feat/verify-current-version-vs-latest branch from 6085f46 to 0b835db Compare October 22, 2024 23:04
@XaaXaaX
Copy link
Copy Markdown
Author

XaaXaaX commented Oct 22, 2024

Related to SDK latest release event-catalog/sdk#44
Generator write a service version in versioned folder if under treatment current version in inferior of latest version

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants