Skip to content

update#69

Merged
boyney123 merged 9 commits intomainfrom
schema-update-4
Jun 4, 2025
Merged

update#69
boyney123 merged 9 commits intomainfrom
schema-update-4

Conversation

@boyney123
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Jun 4, 2025

EventCatalog: Schema Review

The following schemas were modified in this pull request:

Inventory adjusted (1.0.1) (🚨 Danger)

Schema Format Risk Score
json 40/100

The removal of the 'Department' field from the schema is a breaking change that may impact consumers relying on this field. This change violates backward compatibility and could disrupt downstream systems that expect the 'Department' field in the event data.

Potential Effected Consumers

  • Notifications (0.0.2) - The removal of the 'Department' field may cause issues for the Notifications service if it relies on this field for processing or displaying information. Ensure that the service can handle the absence of this field gracefully.

Order confirmed (0.0.1) (🚨 Danger)

Schema Format Risk Score
json 40/100

The schema changes introduce a new optional field 'productDescription' and change the 'quantity' field type from integer to string, which is a breaking change. This may affect consumers expecting an integer type for 'quantity'. The changes are not fully backward compatible and may impact downstream systems relying on the previous schema version.

Potential Effected Consumers

  • Inventory Service (0.0.2) - The change of 'quantity' field type from integer to string is a breaking change. Inventory Service may fail to process events if it expects 'quantity' as an integer.

Inventory adjusted (1.0.0) (✅ Safe)

Schema Format Risk Score
json 85/100

The schema change introduces a new field 'LastName', which is backward compatible as it adds a new optional field. However, the lack of a version number in the schema violates EDA best practices. The change is generally safe but requires careful consideration of downstream consumers that may not handle the new field gracefully.

Potential Effected Consumers

  • Notifications (0.0.2) - The Notifications service may not be prepared to handle the new 'LastName' field, which could lead to unexpected behavior if the service assumes a fixed schema.

List inventory list (0.0.1) (✅ Safe)

Schema Format Risk Score
json 95/100

The schema change introduces a new optional filter 'productName' to the 'filters' object, which is backward compatible as it does not affect existing required properties or constraints. This change is low risk and should not impact existing consumers negatively, as it maintains backward compatibility and adheres to EDA best practices.

Potential Effected Consumers

  • Inventory Service (0.0.2) - The Inventory Service may need to handle the new 'productName' filter if it is used by clients. Ensure that the service logic is updated to process this filter appropriately to avoid unexpected behavior.

Using Model: gpt-4o | Provider: openai

@boyney123 boyney123 merged commit 0b0a17d into main Jun 4, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant