Skip to content

Fixes - #76

Open
avrdude-t wants to merge 4 commits into
eventhorizon5:masterfrom
avrdude-t:fixes2
Open

Fixes#76
avrdude-t wants to merge 4 commits into
eventhorizon5:masterfrom
avrdude-t:fixes2

Conversation

@avrdude-t

@avrdude-t avrdude-t commented Nov 23, 2025

Copy link
Copy Markdown
Contributor

Here is a small patch-set for you with some fixes.

  1. CMake: Include header files in generated project to make working in IDEs like Visual Studio easier: Add all *.h files to the generated solution so they can be accessed from the Solution Explorer.
  2. Add includes to prevent build errors: Refactor some include statements, and also undefine "LoadLibrary" from windows.h in vm.cpp as it was conflicting with VM::LoadLibrary
  3. frontend: Activate menu buttons on mouse-up instead of mouse-down (fixes regression introduced in 8caeccf)

Quix0r
Quix0r suggested changes Nov 24, 2025
View reviewed changes
Comment thread CMakeLists.txt
eventhorizon5 pushed a commit that referenced this pull request Mar 6, 2026
@avrdude-t @eventhorizon5
indentation (#76)
b566124
eventhorizon5 added a commit that referenced this pull request Mar 6, 2026
@eventhorizon5
Merge branch 'pr/76' (#76)
f57c4ef
@eventhorizon5

eventhorizon5 commented Mar 6, 2026

Copy link
Copy Markdown
Owner

I've merged the changes, thanks for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Quix0r Quix0r Quix0r approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avrdude-t @eventhorizon5 @Quix0r