fix(ssr): return 500 on render error instead of hanging; partial data… - #967
Merged
Conversation
… on field error
- renderProduction runs inside a floated promise, so a throw never reached the
calling middleware's try/catch and the request hung until requestTimeout fired
(no status, no body). Thread `next` through render/renderProduction and forward
render-time errors to the error handler so the client gets a proper 500.
- A single failing or non-critical GraphQL field aborted the whole SSR page with
a 500. Log field errors and render with whatever data resolved (partial, or {})
instead of discarding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… on field error
nextthrough render/renderProduction and forward render-time errors to the error handler so the client gets a proper 500.PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information