-
Notifications
You must be signed in to change notification settings - Fork 16
React to preact #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
RamazanIttiev
wants to merge
15
commits into
evilmartians:main
Choose a base branch
from
RamazanIttiev:react-to-preact
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
React to preact #21
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
599234c
config files from react to preact
RamazanIttiev 7e66608
replaced react types
RamazanIttiev aa619c6
replaced react tooltip with floating/dom
RamazanIttiev 1a32d9f
fixed eslint bugs
RamazanIttiev eef6613
fixed tooltip bugs
RamazanIttiev 5c28261
fixed eslint bugs
RamazanIttiev 216084d
removed packageManager from package.json
RamazanIttiev 08f41ce
fixed figma types
RamazanIttiev b5098a5
removed @preact/compat and fixed .yaml
RamazanIttiev b2b05d9
removed @preact/signals-core
RamazanIttiev 7c12493
fixed Tooltip.tsx
RamazanIttiev 4cb77c2
removed unnecessary paths
RamazanIttiev 90c435e
removed react-use-clipboard
RamazanIttiev 17e8ebe
removed packageManager
RamazanIttiev ea33da9
removed @floating-ui/react
RamazanIttiev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issue: I'm not sure, but could we completely get rid of
reactin any form? Remove or rename this prop?Otherwise, good job, thank you 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually we cant. There is no such rule as
preact/jsx-no-bind. I have tried to remove it but es lint tests don't pass