required Ruby 2.7, add new CI workflow with graphql-ruby master branch#14
required Ruby 2.7, add new CI workflow with graphql-ruby master branch#14prog-supdex wants to merge 2 commits intoevilmartians:masterfrom
Conversation
.github/workflows/ruby.yml
Outdated
| fail-fast: false | ||
| matrix: | ||
| ruby: [ '2.6', '2.7', '3.0' ] | ||
| ruby: [ '2.7', '3.0', '3.1', '3.2' ] |
There was a problem hiding this comment.
2.7 is dead for 7 months already, maybe we can drop it too?
There was a problem hiding this comment.
hm, okay, thanks :)
done
palkan
left a comment
palkan
left a comment
There was a problem hiding this comment.
Added a comment.
And, rebase, please.
| DATABASE_URL: postgres://postgres:postgres@localhost:5432 | ||
| ELASTICSEARCH_URL: http://localhost:9200 |
There was a problem hiding this comment.
Why do we need these two? The setup must be similar to ruby.yml, the only difference is the Gemfile.
And I'm not sure we need to extract this into a separate workflow; it can be another parameter in the ruby.yml matrix.
Also, ruby_edge is a confusing name; we're not testing against edge Ruby but graphql gem.
There was a problem hiding this comment.
Because in the matrix we put "head" ruby (for master ruby), and this ruby version puts RUBY_VERSION to the docker file through env (it is default, like ci cd looks for ruby.yml).
So Docker doesn't know about the "head" ruby version.
Also, I couldn't find the image with the master ruby
About naming - OK, agree
3 participants
Context
Required Ruby 2.7 and added a new workflow with checking graphql-ruby master branch