FIX: Error when linking to absolute URLs with absolute links to images#207
Open
eviltrout wants to merge 1 commit intoevilstreak:masterfrom
Open
FIX: Error when linking to absolute URLs with absolute links to images#207eviltrout wants to merge 1 commit intoevilstreak:masterfrom
eviltrout wants to merge 1 commit intoevilstreak:masterfrom
Conversation
Collaborator
|
At times I wish I hadn't built this around regexps :( That 🚢 has long since sailed. Change looks okay - could you look at what happened to the node 0.8 tests in travis? |
Contributor
Author
|
Looks like a random npm failure to me? I didn't change any deps. |
Collaborator
|
Hmmmm its seemed to have been failing for about a month https://travis-ci.org/evilstreak/markdown-js/pull_requests Bet its some annoyance in a dep that no longer supports node.js 0.8.... Bah. So we either need to pin grunt (at a guess) to an older version, or drop support for 0.10... thoughts either way? |
Contributor
Author
|
We only use it in browsers so I have no insight into node versions. But 0.8 is quite old isn't it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matching URLs with regular expressions is tough! However, this approach fixes issues when linking to absolute URLs with absolute image URLs inside them.