Fix Zod version compatibility for SDK users#135
Open
MiguelAtExa wants to merge 1 commit intomasterfrom
Open
Conversation
|
Zod has a guide on how to support both versions at the same time: https://zod.dev/library-authors?id=how-to-support-zod-3-and-zod-4-simultaneously The better solution they recommend, though, is to support standard-schema instead. From a quick look at the code, it seems the zod schema is converted to a json schema, so the better approach might be to use standard-json-schema and maybe keep a special implementation for zod 4 for backwards compatibility. In any case, pulling in zod 3 is a show-stopper for me :( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
zodfrom a bundled dependency to an optional peer dependency (>=3.24.1) and replaces theinstanceof ZodTypecheck inzod-utils.tswith duck-type detection (safeParse,parse,_def). Previously, bundling zod as a regular dependency meant users ended up with two copies of zod in their node_modules — theirs and the SDK's — causinginstanceofchecks to fail silently when users passed their own Zod schemas tooutputSchemaorsummary.schema. The duck-type approach works across any Zod instance or version, and marking the peer dep as optional means users who don't use schema features aren't forced to install zod at all. Also converts theZodSchemaimports inindex.tsandresearch/client.tsto type-only imports so they're erased at compile time.