Closed
Conversation
Co-Authored-By: Max <maxwbuckley@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Contributor
|
Closing — |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
deep-maxto theDeepSearchTypeunion, aligning the JS SDK with the API which already accepts this type. This meansdeep-maxnow gets proper TypeScript type support andadditionalQueriesis correctly allowed with it (viaDeepSearchOptions).Review & Testing Checklist for Human
deep-maxis live and accepted by the API (the docs page lists it, and Vulcan'sSearchTypeSchemaincludes it)deep-maxshould supportadditionalQueries— by being inDeepSearchType, it inheritsDeepSearchOptionswhich includes that fieldNotes
Companion PR for exa-py adds the same type there.
Link to Devin session: https://app.devin.ai/sessions/37d00c74a58c46af92847ccdad46699e
Requested by: @maxwbuckley