Skip to content

feat(exa-js): add deep-max search type#160

Closed
maxwbuckley wants to merge 1 commit intomasterfrom
devin/1775653011-add-deep-max-search-type
Closed

feat(exa-js): add deep-max search type#160
maxwbuckley wants to merge 1 commit intomasterfrom
devin/1775653011-add-deep-max-search-type

Conversation

@maxwbuckley
Copy link
Copy Markdown
Contributor

@maxwbuckley maxwbuckley commented Apr 8, 2026

Summary

Adds deep-max to the DeepSearchType union, aligning the JS SDK with the API which already accepts this type. This means deep-max now gets proper TypeScript type support and additionalQueries is correctly allowed with it (via DeepSearchOptions).

Review & Testing Checklist for Human

  • Verify deep-max is live and accepted by the API (the docs page lists it, and Vulcan's SearchTypeSchema includes it)
  • Confirm deep-max should support additionalQueries — by being in DeepSearchType, it inherits DeepSearchOptions which includes that field

Notes

Companion PR for exa-py adds the same type there.

Link to Devin session: https://app.devin.ai/sessions/37d00c74a58c46af92847ccdad46699e
Requested by: @maxwbuckley


Open with Devin

Co-Authored-By: Max <maxwbuckley@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional finding.

Open in Devin Review

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Closing — deep-max shouldn't be a public search type. Will be removed from documentation instead.

@devin-ai-integration devin-ai-integration bot deleted the devin/1775653011-add-deep-max-search-type branch April 9, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant