Skip to content

chore: sync with upstream aws/karpenter-provider-aws main#1

Open
jeremywgleeson wants to merge 6 commits intomainfrom
devin/1773537339-sync-upstream-main
Open

chore: sync with upstream aws/karpenter-provider-aws main#1
jeremywgleeson wants to merge 6 commits intomainfrom
devin/1773537339-sync-upstream-main

Conversation

@jeremywgleeson
Copy link
Copy Markdown

@jeremywgleeson jeremywgleeson commented Mar 15, 2026

chore: sync with upstream aws/karpenter-provider-aws main

Summary

Merges 5 upstream commits from aws/karpenter-provider-aws main into the exa fork. The exa-specific commits ([karpenter] Point to local fork of karpenter and [karpenter] Add flake + fix Makefile) are preserved.

Key upstream changes:

  • fix: prevent RequestLimitExceeded CreateFleet errors from marking ODCRs unavailable (pkg/providers/instance/instance.go) — now only unfulfillable-capacity errors mark reservations unavailable, preventing throttling from incorrectly disabling capacity reservations
  • chore: Add instances ineligible for free tier error — new error classification
  • chore(deps): AWS SDK v2, ginkgo/gomega, golang.org/x/* bumps
  • chore(deps-dev): tar 7.5.6 → 7.5.9 (website)
  • chore: Bump upstream karpenter version — core dep moves to v1.9.1-prerelease

The go.sum conflict was resolved by taking upstream's version (git checkout --theirs go.sum).

Review & Testing Checklist for Human

  • Verify go.sum correctness: The conflict was resolved by taking upstream's go.sum wholesale. Since the exa fork uses replace sigs.k8s.io/karpenter => ../base in go.mod, the actual transitive deps may differ from what upstream expects. Run go mod tidy with the local ../base directory at the correct commit to regenerate go.sum and confirm it matches.
  • Verify build compiles: This PR should only be merged after the companion karpenter core sync PR lands, since go.mod references ../base and the core karpenter dependency version has changed upstream. Building with a stale ../base may fail.
  • Confirm ODCR fix is desirable: The capacity reservation error handling change (instance.go) is a behavioral fix — verify this aligns with how exa uses ODCRs in production.

Notes

  • Requested by: @jeremywgleeson
  • Devin Session
  • Companion PR: exa-labs/karpenter#3 (core fork upstream sync)
  • Next steps: merge both sync PRs → rebase jeremy/rolling-restart-consolidation on updated main → run tests → merge rolling restart

Open with Devin

jigisha620 and others added 6 commits February 24, 2026 11:05
aws#8980)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-Authored-By: jeremy <jeremywgleeson@gmail.com>
@devin-ai-integration
Copy link
Copy Markdown

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Copy Markdown

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 4 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants