Skip to content

fix(rayjob): use grace period env var for submitter finished timeout #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jld-adriano wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(rayjob): use grace period env var for submitter finished timeout #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions ray-operator/controllers/ray/rayjob_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,20 +1131,28 @@ func checkSubmitterFinishedTimeoutAndUpdateStatusIfNeeded(ctx context.Context, r
return false
}

// Read the grace period from the env var, falling back to the hardcoded default.
// This reuses the same env var as checkTransitionGracePeriodAndUpdateStatusIfNeeded
// so operators only need to configure one knob.
submitterTimeout := DefaultSubmitterFinishedTimeout
if gracePeriodSeconds, err := strconv.Atoi(os.Getenv(utils.RAYJOB_DEPLOYMENT_STATUS_TRANSITION_GRACE_PERIOD_SECONDS)); err == nil && gracePeriodSeconds > 0 {
submitterTimeout = time.Duration(gracePeriodSeconds) * time.Second
}

// Check if timeout has been exceeded
if time.Now().Before(finishedAt.Add(DefaultSubmitterFinishedTimeout)) {
if time.Now().Before(finishedAt.Add(submitterTimeout)) {
return false
}

logger.Info("The RayJob has passed the submitterFinishedTimeoutSeconds. Transition the status to terminal.",
"SubmitterFinishedTime", finishedAt,
"SubmitterFinishedTimeoutSeconds", DefaultSubmitterFinishedTimeout.String())
"SubmitterFinishedTimeoutSeconds", submitterTimeout.String())

rayJob.Status.JobStatus = rayv1.JobStatusFailed
rayJob.Status.JobDeploymentStatus = rayv1.JobDeploymentStatusFailed
rayJob.Status.Reason = rayv1.JobDeploymentStatusTransitionGracePeriodExceeded
rayJob.Status.Message = fmt.Sprintf("The RayJob submitter finished at %v but the ray job did not reach terminal state within %v",
finishedAt.Format(time.DateTime), DefaultSubmitterFinishedTimeout)
finishedAt.Format(time.DateTime), submitterTimeout)
return true
}

Expand Down
Loading